fix: nk_option_text* unticking itself when not visible#944
Open
sleeptightAnsiC wants to merge 1 commit intoImmediate-Mode-UI:masterfrom
Open
fix: nk_option_text* unticking itself when not visible#944sleeptightAnsiC wants to merge 1 commit intoImmediate-Mode-UI:masterfrom
sleeptightAnsiC wants to merge 1 commit intoImmediate-Mode-UI:masterfrom
Conversation
RobLoach
approved these changes
Apr 21, 2026
Every branch in those functions returns `is_active` but not those two, which was clearly a bug that could manifest in rare occasions. See linked issue for more information. Fixes: Immediate-Mode-UI#853 Co-authored-by: StewBC <swessels@email.com>
sleeptightAnsiC
force-pushed
the
fix__option_text_unticking
branch
from
a117c1c to
1957d8b
Compare
Contributor
Author
|
no changes in latest force push, just added StewBC as commit co-author :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every branch in those functions returns
is_activebut not those two,which was clearly a bug that could manifest in rare occasions.
See linked issue for more information.
Fixes: #853