[Refactor] Timestamp links in comments open external browser instead of seeking video#13416
Open
Ecomont wants to merge 5 commits intoTeamNewPipe:refactorfrom
Open
[Refactor] Timestamp links in comments open external browser instead of seeking video#13416Ecomont wants to merge 5 commits intoTeamNewPipe:refactorfrom
Ecomont wants to merge 5 commits intoTeamNewPipe:refactorfrom
Conversation
ShareASmile
added
bug
ShareASmile
added
the
regression
theimpulson
requested changes
Apr 16, 2026
Member
theimpulson
left a comment
theimpulson
left a comment
There was a problem hiding this comment.
Thank you for the work. Please address some minor nitpicks. Looks good to me otherwise.
Member
|
It would be nice to make sure the functionality change, if any, gets mirrored in dev as well even if it needs rewrite to ensure both branch behaves the same. |
|
Nice! This partially solves #11715. |
AudricV
reviewed
Apr 16, 2026
When a timestamp link in the video description is tapped, expand the AppBar to reveal the player in addition to seeking. This mirrors the existing behaviour in the comments tab
github-actions
bot
added
size/large
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
DescriptionTextin Compose.onTimestampClickcallback from the comments UI down to the text component.Before/After Screenshots/Screen Record
bugVideo.mp4
afterVideo.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence