Use the provided mimetype in B2FileList.upload#26
Open
Katharine wants to merge 1 commit intosibblegp:masterfrom
Open
Use the provided mimetype in B2FileList.upload#26Katharine wants to merge 1 commit intosibblegp:masterfrom
Katharine wants to merge 1 commit intosibblegp:masterfrom
Conversation
8a29346 to
ac70185
Compare
Owner
|
What happens if mime_content_type is None? Will it auto detect it? |
Author
|
Yes — in that case the connector code defaults to |
Owner
|
Hi Katharine. I'm glad you contributed so much to the project. Is there a way we could talk privately about making you a direct contributor?
Sincerely,
George P. Sibble
…On Thu, Oct 10, 2019 at 11:27 AM, Katharine Berry < ***@***.*** > wrote:
Yes — in that case the connector code defaults to b2/x-auto (
https://github.com/sibblegp/b2blaze/blob/ac70185a1e16fb3bc7ce6c974b16fdbdbdb5234b/b2blaze/connector.py#L128
) , which guesses from the file extension.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub (
#26?email_source=notifications&email_token=AAH2TKXYIPWX7L47YVWPGYTQN5XXTA5CNFSM4GQBC5PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA5KAPI#issuecomment-540713021
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAH2TKUZHPLUVG2VSIQ2U6LQN5XXTANCNFSM4GQBC5PA
).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value passed for
mime_content_typetoB2FileList.uploadwas being discarded, leaving filename-based autodetection on in all cases.Change
uploadto pass the mimetype through to the connector (which then handles it correctly).